Sandro Bonazzola has posted comments on this change. Change subject: bin: add the host to the first cluster if 'Default' dosn't exist ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25456/2/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 414: ], Line 415: ca_file=self.cert, Line 416: ) Line 417: self.logger.debug('Adding the host to the cluster') Line 418: cluster_l=[c.get_name() for c in engine_api.clusters.list()] pep8 errors: ./add_host.py:402:21: E225 missing whitespace around operator ./add_host.py:418:22: E225 missing whitespace around operator ./add_host.py:419:25: E225 missing whitespace around operator Line 419: cluster_name='Default' if cluster_name not in cluster_l \ Line 420: else cluster_l[0] Line 421: engine_api.hosts.add( Line 422: self._ovirtsdk_xml.params.Host( -- To view, visit http://gerrit.ovirt.org/25456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00167e70296645e5cf732b64d87efa1cf66ca783 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Meital Bourvine <mbour...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <simone.tirabos...@gmail.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
