Yedidyah Bar David has posted comments on this change. Change subject: bin: add the host to the first cluster if 'Default' dosn't exist ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25456/2/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 416: ) Line 417: self.logger.debug('Adding the host to the cluster') Line 418: cluster_l=[c.get_name() for c in engine_api.clusters.list()] Line 419: cluster_name='Default' if cluster_name not in cluster_l \ Line 420: else cluster_l[0] > I see the point in using the first cluster available if Default is missing. I know that generally we try to ask all the questions at customization and then continue unattended, but I actually do not think there is a problem breaking that rule. Specifically I see no problem with either of: 1. Do not ask at customization, use 'Default' by default 2. Ask and then, if it fails, show the user a list of the existing DCs and allow choosing (having the first as default answer). If none exist, we can even tell the user to create one and then ask (or choose the first one), if we want to go the extra mile. > Maybe we should allow to choose the cluster between existing regardless of > Default being there if more than one exist? Always? I'd rather ask first, then. Will allow easier automation. Line 421: engine_api.hosts.add( Line 422: self._ovirtsdk_xml.params.Host( Line 423: name=self.environment[ Line 424: ohostedcons.EngineEnv.APP_HOST_NAME -- To view, visit http://gerrit.ovirt.org/25456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00167e70296645e5cf732b64d87efa1cf66ca783 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Meital Bourvine <mbour...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <simone.tirabos...@gmail.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
