Sandro Bonazzola has posted comments on this change. Change subject: bin: add the host to the first cluster if 'Default' dosn't exist ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25456/2/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 416: ) Line 417: self.logger.debug('Adding the host to the cluster') Line 418: cluster_l=[c.get_name() for c in engine_api.clusters.list()] Line 419: cluster_name='Default' if cluster_name not in cluster_l \ Line 420: else cluster_l[0] I see the point in using the first cluster available if Default is missing. Allowing the user to specify a cluster at customization stage may lead to having a failure here if the user change his/her mind and use a different name. Maybe we should allow to choose the cluster between existing regardless of Default being there if more than one exist? Line 421: engine_api.hosts.add( Line 422: self._ovirtsdk_xml.params.Host( Line 423: name=self.environment[ Line 424: ohostedcons.EngineEnv.APP_HOST_NAME -- To view, visit http://gerrit.ovirt.org/25456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00167e70296645e5cf732b64d87efa1cf66ca783 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Meital Bourvine <mbour...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <simone.tirabos...@gmail.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
