Alon Bar-Lev has posted comments on this change. Change subject: Update the build process to determine versioning using git tags ......................................................................
Patch Set 1: Code-Review-1 I try to avoid reviewing any more packages... However, this is incorrect. autoconf package should be atomic, the autogen.sh script is optional and should contain single command: autoreconf -ivf any dependency in this script is invalid. acquiring version information should be in Makefile.am prior of make dist. see openvpn for example[1][2] For the general approach, there is no real reason to produce git hash, as package should be built using release_suffix with that information as parameter to rpmbuild or any other build process. [1] https://github.com/OpenVPN/openvpn/blob/master/Makefile.am#L92 [2] https://github.com/OpenVPN/openvpn/blob/master/Makefile.am#L52 -- To view, visit http://gerrit.ovirt.org/25404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacfec13ee13abf05c781d820e865b2d4d54398ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
