Kiril Nesenko has posted comments on this change.
Change subject: Update the build process to determine versioning using git tags
......................................................................
Patch Set 1: Code-Review-1
I do agree with Sandro that we do not need git suffix like in vdsm.
I think we should follow the standard build process:
autoreconf -ivf
./configure
make dist
SUFFIX=".$(date --utc +%Y%m%d).git$(git rev-parse --short HEAD)"
rpmbuild -D "_topdir $(pwd)/rpmbuild" -D "release_suffix ${SUFFIX}" -ts *.gz
rpmbuild -D "_topdir $(pwd)/rpmbuild" -D "release_suffix ${SUFFIX}" --rebuild
rpmbuild/SRPMS/*.src.rpm
--
To view, visit http://gerrit.ovirt.org/25404
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacfec13ee13abf05c781d820e865b2d4d54398ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
