Martin Sivák has posted comments on this change. Change subject: Update the build process to determine versioning using git tags ......................................................................
Patch Set 1: There are reasons for this change: 1) I want the release process to be automatic and unified (there will be a Jenkins job to take care of that) 2) I want the process for release and for nightly build to be as similar as possible 3) The ability to get the exact git commit used for any build (both nightly and release) is useful for debugging 4) Our versioning is a mess and violates RPM rules regarding version and release parts (http://www.rpm.org/max-rpm/ch-rpm-file-format.html) Regarding your comments - the version collision won't happen if you obey the rules I described in README.maintainers (add extra digit when you create a branch). And only maintainers are allowed to create release branches anyway. -- To view, visit http://gerrit.ovirt.org/25404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacfec13ee13abf05c781d820e865b2d4d54398ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
