Liran Zelkha has posted comments on this change.

Change subject: core: Remove usage of dynamic queries from the Backend
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/24310/11/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java:

Line 212:         if (!isFiltered()) {
Line 213:             StorageDomain storageDomain = 
getEntity(org.ovirt.engine.core.common.businessentities.StorageDomain.class,
Line 214:                     VdcQueryType.GetStorageDomainByName,
Line 215:                     new NameQueryParameters(name),
Line 216:                     name);
> We agreed to preserve the message, but it was lost, maybe during a rebase?
Done
Line 217: 
Line 218:             if (storageDomain != null) {
Line 219:                 return storageDomain.getId();
Line 220:             }


-- 
To view, visit http://gerrit.ovirt.org/24310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3df981a958fae36edd6ecf3cb2bb47b94b2c446a
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to