Liran Zelkha has posted comments on this change.

Change subject: core: Remove usage of dynamic queries from the Backend
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.ovirt.org/#/c/24310/12/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResourceTest.java
File 
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResourceTest.java:

Line 65:     public void testGet() throws Exception {
Line 66:         setUriInfo(setUpBasicUriExpectations());
Line 67:         setUpEntityQueryExpectations(VdcQueryType.GetAllDbUsers,
Line 68:                 VdcQueryParametersBase.class,
Line 69:                 new String[] {},
> Done
Why? I don't think this test run before with filtered. It messes up the whole 
test
Line 70:                 new Object[] {},
Line 71:                 getUsers());
Line 72: 
Line 73:         setUpGetEntityExpectations();


-- 
To view, visit http://gerrit.ovirt.org/24310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3df981a958fae36edd6ecf3cb2bb47b94b2c446a
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to