Liran Zelkha has posted comments on this change. Change subject: core: Remove usage of dynamic queries from the Backend ......................................................................
Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/24310/10/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java: Line 183: List<StorageDomain> getPermittedStorageDomainsByStoragePool(Guid userId, ActionGroup actionGroup, Guid storagePoolId); Line 184: Line 185: /** Line 186: * Retrieves the storage domain with specified name, with optional permissions filtering. Line 187: * @param id > param don't match real name Done Line 188: * the storage domain name Line 189: * @param userID Line 190: * the ID of the user requesting the information Line 191: * @param isFiltered Line 187: * @param id Line 188: * the storage domain name Line 189: * @param userID Line 190: * the ID of the user requesting the information Line 191: * @param isFiltered > param don't match real name Done Line 192: * Whether the results should be filtered according to the user's permissions Line 193: * @return the storage domain Line 194: */ Line 195: http://gerrit.ovirt.org/#/c/24310/10/packaging/dbscripts/storages_sp.sql File packaging/dbscripts/storages_sp.sql: Line 432: Line 433: END; $procedure$ Line 434: LANGUAGE plpgsql; Line 435: Line 436: Create or replace FUNCTION Getstorage_domains_By_name(v_name CHARACTER VARYING, v_user_id UUID, v_is_filtered BOOLEAN) > CHARACTER VARYING=> varchar(250) Done Line 437: RETURNS SETOF storage_domains_without_storage_pools STABLE Line 438: AS $procedure$ Line 439: BEGIN Line 440: RETURN QUERY SELECT * -- To view, visit http://gerrit.ovirt.org/24310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3df981a958fae36edd6ecf3cb2bb47b94b2c446a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
