Juan Hernandez has posted comments on this change.

Change subject: core: Remove usage of dynamic queries from the Backend
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/24310/8/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentResource.java
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentResource.java:

Line 84:     protected VDSGroup lookupClusterByName(String name) {
Line 85:         return getEntity(VDSGroup.class,
Line 86:                 VdcQueryType.GetVdsGroupByName,
Line 87:                 new NameQueryParameters(name),
Line 88:                 name);
> Juan, 
I don't have any objection to preserve the message. Liran, please do it.
Line 89:     }
Line 90: 
Line 91:     protected VDSGroup lookupClusterById(String id) {
Line 92:         return getEntity(VDSGroup.class,


-- 
To view, visit http://gerrit.ovirt.org/24310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3df981a958fae36edd6ecf3cb2bb47b94b2c446a
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to