Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introducing extensions module ......................................................................
Patch Set 4: (2 comments) looks ok, two minor comments at spec http://gerrit.ovirt.org/#/c/25192/4/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 575: %{engine_ear}/userportal.war/WEB-INF/lib/branding.jar Line 576: %{engine_ear}/webadmin.war/WEB-INF/lib/branding.jar Line 577: %{engine_ear}/welcome.war/WEB-INF/lib/branding.jar Line 578: %{engine_jboss_modules}/org/ovirt/engine/core/aaa/main/aaa.jar Line 579: %{engine_jboss_modules}/org/ovirt/engine/api/ovirt-engine-extensions-api/main/ovirt-engine-extensions-api.jar please sort Line 580: %{engine_jboss_modules}/org/ovirt/engine/core/common/main/common.jar Line 581: %{engine_jboss_modules}/org/ovirt/engine/core/compat/main/compat.jar Line 582: %{engine_jboss_modules}/org/ovirt/engine/core/dal/main/dal.jar Line 583: %{engine_jboss_modules}/org/ovirt/engine/core/extension-manager/main/extension-manager.jar Line 780: %{engine_data}/branding/ovirt.brand/ Line 781: %{engine_etc}/branding/00-ovirt.brand Line 782: %{engine_etc}/engine.conf.d/ Line 783: %{engine_java}/aaa.jar Line 784: %{engine_java}ovirt-engine-extensions-api.jar missing / + sort Line 785: %{engine_java}/branding.jar Line 786: %{engine_java}/common.jar Line 787: %{engine_java}/compat.jar Line 788: %{engine_java}/extension-manager.jar -- To view, visit http://gerrit.ovirt.org/25192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If373ef883588fdf363f5800fa8fc74c7836838cd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
