Yair Zaslavsky has posted comments on this change. Change subject: aaa: Introducing extensions module ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/25192/3/backend/manager/dependencies/src/main/modules/org/ovirt/engine/api/extensions/main/module.xml File backend/manager/dependencies/src/main/modules/org/ovirt/engine/api/extensions/main/module.xml: Line 1: <?xml version="1.0" encoding="UTF-8"?> Line 2: <module xmlns="urn:jboss:module:1.1" name="org.ovirt.engine.api.extensions"> Line 3: <resources> Line 4: <resource-root path="extensions.jar"/> > can we call the jar ovirt-engine-extensions.jar so we won't have conflict w Done Line 5: </resources> http://gerrit.ovirt.org/#/c/25192/3/backend/manager/modules/extensions-api-root/extensions-api/pom.xml File backend/manager/modules/extensions-api-root/extensions-api/pom.xml: Line 7: <artifactId>extensions-api-root</artifactId> Line 8: <version>0.0.0-SNAPSHOT</version> Line 9: </parent> Line 10: Line 11: <artifactId>extensions</artifactId> > can we have this ovirt-engine-extenstions-api? Done Line 12: <packaging>jar</packaging> Line 13: Line 14: <name>extensions-api</name> Line 15: Line 10: Line 11: <artifactId>extensions</artifactId> Line 12: <packaging>jar</packaging> Line 13: Line 14: <name>extensions-api</name> > why name differ from artifactId? Done Line 15: Line 16: <profiles> Line 17: <profile> Line 18: <id>findbugs</id> -- To view, visit http://gerrit.ovirt.org/25192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If373ef883588fdf363f5800fa8fc74c7836838cd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
