Yair Zaslavsky has posted comments on this change. Change subject: aaa: Introducing extensions module ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/25192/6/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/internal/InternalDirectory.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/internal/InternalDirectory.java: Line 9: import org.ovirt.engine.core.aaa.DirectoryUser; Line 10: import org.ovirt.engine.core.common.config.Config; Line 11: import org.ovirt.engine.core.common.config.ConfigValues; Line 12: import org.ovirt.engine.core.common.utils.ExternalId; Line 13: import org.ovirt.engine.api.extensions.Extension.ExtensionProperties; > why do you need to import this and not just use Extension.Properties ? we can, i don't mind either way. Line 14: Line 15: /** Line 16: * This directory contains only the internal user as specified in the {@code AdminUser} configuration parameter. Line 17: */ http://gerrit.ovirt.org/#/c/25192/6/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 784: %{engine_java}/branding.jar Line 785: %{engine_java}/common.jar Line 786: %{engine_java}/compat.jar Line 787: %{engine_java}/extension-manager.jar Line 788: %{engine_java}ovirt-engine-extensions-api.jar > I already commented this... please add '/' and sort() sorry, for some reason i was sure the version i sent addressed this. Line 789: %{engine_java}/utils.jar Line 790: Line 791: # Line 792: # ATTENTION: -- To view, visit http://gerrit.ovirt.org/25192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If373ef883588fdf363f5800fa8fc74c7836838cd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
