Alon Bar-Lev has posted comments on this change. Change subject: aaa: logs all enabled extensions ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/24979/5/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java: Line 247: Map<ExtensionProperties, Object> context = entry.extension.getContext(); Line 248: if (entry.extension != null) { Line 249: log.info(String.format( Line 250: "Name: '%1$s', Author '%2$s', Version '%3$s', Home: '%4$s' License: '%5$s' File: '%6$s'", Line 251: emptyIfNull(context.get(ExtensionProperties.EXTENSION_NAME)), oh! we are missing instance name... and lets reorder: instance_name, extension_name, version, license, home, author, file sorry for the late comment. Line 252: emptyIfNull(context.get(ExtensionProperties.AUTHOR)), Line 253: emptyIfNull(context.get(ExtensionProperties.VERSION)), Line 254: emptyIfNull(context.get(ExtensionProperties.HOME)), Line 255: emptyIfNull(context.get(ExtensionProperties.LICENSE)), -- To view, visit http://gerrit.ovirt.org/24979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99a7278cbcbbe54e2d3cb1dd96f6eda6100ae2ff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
