[Engine-patches] Change in ovirt-engine[master]: aaa: logs all activated extensions

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: aaa: logs all activated extensions
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.ovirt.org/#/c/24979/2/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java
File 
backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java:

Line 235:                     }
Line 236:                 }
Line 237:             }
Line 238:         }
Line 239:         log.info("Activated extensions list: ");
I would have moved it to own function...
Line 240:         for (ExtensionEntry entry: loadedEntries.values()) {
Line 241:             if (entry.extension != null) {
Line 242:                 log.info(
Line 243:                         String.format(


Line 246:                                 
emptyIfNull(entry.extension.getContext().get(ExtensionProperties.AUTHOR)),
Line 247:                                 
emptyIfNull(entry.extension.getContext().get(ExtensionProperties.VERSION)),
Line 248:                                 
emptyIfNull(entry.extension.getContext().get(ExtensionProperties.HOME)),
Line 249:                                 
emptyIfNull(entry.extension.getContext().get(ExtensionProperties.LICENSE))
Line 250:                         )
why two indents each?

in this case context variable before the log.info will be handy :)

please add file as last field.
Line 251:                 );
Line 252:             }
Line 253:         }
Line 254:         log.info("End of activated extensions list");


Line 250:                         )
Line 251:                 );
Line 252:             }
Line 253:         }
Line 254:         log.info("End of activated extensions list");
if this is the epilogue then the prologue should be:

 Start of extension list
 ....
 End of extension list

activated -> enabled?
Line 255:     }
Line 256: 
Line 257:     private String emptyIfNull(Object value) {
Line 258:         return value == null ? "" : value.toString();


-- 
To view, visit http://gerrit.ovirt.org/24979
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99a7278cbcbbe54e2d3cb1dd96f6eda6100ae2ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches