Yair Zaslavsky has posted comments on this change. Change subject: aaa: logs all enabled extensions ......................................................................
Patch Set 7: (4 comments) http://gerrit.ovirt.org/#/c/24979/7/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java: Line 244: Line 245: private void logEnabledExtensions() { Line 246: log.info("Start of enabled extensions list"); Line 247: for (ExtensionEntry entry: loadedEntries.values()) { Line 248: if (entry.extension != null && entry.enabled) { > how can it enabled but null? done. Line 249: Map<ExtensionProperties, Object> context = entry.extension.getContext(); Line 250: log.info(String.format( Line 251: "Instance name: '%1$s', Extension name: '%2$s', Author '%3$s', Version '%4$s', Home: '%5$s' License: '%6$s' File: '%7$s'", Line 252: emptyIfNull(context.get(ExtensionProperties.NAME)), Line 247: for (ExtensionEntry entry: loadedEntries.values()) { Line 248: if (entry.extension != null && entry.enabled) { Line 249: Map<ExtensionProperties, Object> context = entry.extension.getContext(); Line 250: log.info(String.format( Line 251: "Instance name: '%1$s', Extension name: '%2$s', Author '%3$s', Version '%4$s', Home: '%5$s' License: '%6$s' File: '%7$s'", > please reoder... per previous comment. Done Line 252: emptyIfNull(context.get(ExtensionProperties.NAME)), Line 253: emptyIfNull(context.get(ExtensionProperties.EXTENSION_NAME)), Line 254: emptyIfNull(context.get(ExtensionProperties.AUTHOR)), Line 255: emptyIfNull(context.get(ExtensionProperties.VERSION)), Line 262: } Line 263: log.info("End of enabled extensions list"); Line 264: } Line 265: Line 266: private String emptyIfNull(Object value) { > I would have put Object as return value... Done Line 267: return value == null ? "" : value.toString(); Line 268: } Line 263: log.info("End of enabled extensions list"); Line 264: } Line 265: Line 266: private String emptyIfNull(Object value) { Line 267: return value == null ? "" : value.toString(); > and drop the toString Done Line 268: } -- To view, visit http://gerrit.ovirt.org/24979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99a7278cbcbbe54e2d3cb1dd96f6eda6100ae2ff Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
