Alon Bar-Lev has posted comments on this change. Change subject: 9. [WIP] core: Introducing configuration loader ......................................................................
Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/24365/16/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java: Line 29: private static final String NAME = "ovirt.engine.extension.name"; Line 30: private static final String SERVICE = "ovirt.engine.extension.service"; Line 31: private static final String ENABLED = "ovirt.engine.extension.enabled"; Line 32: private static final String MODULE = "ovirt.engine.extension.module"; Line 33: private static final String TYPE = "ovirt.engine.extension.type"; > When i look at your examples (for instance - the authz) you have - correct, as I figured out in my last comment. so I just suggest to rename the terms to something less confusing. Line 34: Line 35: public class ExtensionEntry { Line 36: private File file; Line 37: private boolean enabled; -- To view, visit http://gerrit.ovirt.org/24365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I182904177ec088e62b35bde870ec79725fabc4e4 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
