Alon Bar-Lev has posted comments on this change. Change subject: 9. [WIP] core: Introducing configuration loader ......................................................................
Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/24365/16/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java: Line 81: config.getString(TYPE))); Line 82: } Line 83: this.extension = extensionClass.newInstance(); Line 84: this.extension.setName(name); Line 85: this.extension.setConfigurationProperties(config.getProperties()); > Not sure I follow, why do i need what here? why do you use "this" as prefix? :) Line 86: Line 87: } catch (InstantiationException | IllegalAccessException | IllegalArgumentException e) { Line 88: throw new ConfigurationException(String.format("Error in instantitating extension based on tye type '%1$'", Line 89: config.getString(TYPE))); -- To view, visit http://gerrit.ovirt.org/24365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I182904177ec088e62b35bde870ec79725fabc4e4 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
