Alon Bar-Lev has posted comments on this change. Change subject: 9. [WIP] core: Introducing configuration loader ......................................................................
Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/24365/16/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java: Line 29: private static final String NAME = "ovirt.engine.extension.name"; Line 30: private static final String SERVICE = "ovirt.engine.extension.service"; Line 31: private static final String ENABLED = "ovirt.engine.extension.enabled"; Line 32: private static final String MODULE = "ovirt.engine.extension.module"; Line 33: private static final String TYPE = "ovirt.engine.extension.type"; > so why do oyu need the service? ok... got it! you need 4... the 4th one is to be able to enumerate based on "authenticator", "events" etc... so I suggest: 1. module 2. class 3. name 4. provides however, I think that under the java way... we should not have (4) at all... what we can do is have: public List<ExtensionEntry> getExtensionsByInterface(Class interface) instead of the service one... this will look for all extensions that implements specific interface, instead of naming. but then once again, it damages my future plans... as we want to publish as few interfaces as possible, so best to have this "provides". so best to have this... I just suggest to rename variables per above naming. Line 34: Line 35: public class ExtensionEntry { Line 36: private File file; Line 37: private boolean enabled; -- To view, visit http://gerrit.ovirt.org/24365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I182904177ec088e62b35bde870ec79725fabc4e4 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
