Greg Padgett has posted comments on this change. Change subject: Separate the state machine into machine, states with logic and communication ......................................................................
Patch Set 7: Code-Review+1 (2 comments) One possible issue, not sure how it looks at runtime but see inline comment. http://gerrit.ovirt.org/#/c/24333/7/ovirt_hosted_engine_ha/agent/hosted_engine.py File ovirt_hosted_engine_ha/agent/hosted_engine.py: Line 317: self._initialize_sanlock() Line 318: self._initialize_domain_monitor() Line 319: Line 320: # log state Line 321: self._log.info("Current state %s (score: %d)", I hate to say it because this is a very useful log message, but: There was a prior bug (https://bugzilla.redhat.com/show_bug.cgi?id=1019471) about the logs rotating too frequently; this may need to be throttled down like some of the other periodic messages. Line 322: state.__class__.__name__, Line 323: state.score(self._log)) Line 324: if state.data.best_score_host: Line 325: self._log.info("Best remote host %s (id: %d, score: %d)", Line 321: self._log.info("Current state %s (score: %d)", Line 322: state.__class__.__name__, Line 323: state.score(self._log)) Line 324: if state.data.best_score_host: Line 325: self._log.info("Best remote host %s (id: %d, score: %d)", same as above Line 326: state.data.best_score_host["hostname"], Line 327: state.data.best_score_host["host-id"], Line 328: state.data.best_score_host["score"]) Line 329: -- To view, visit http://gerrit.ovirt.org/24333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icad82e819b653cd8b9210d0a71e0312fc6b20134 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
