Jiří Moskovčák has posted comments on this change. Change subject: Separate the state machine into machine, states with logic and communication ......................................................................
Patch Set 6: Code-Review+1 (1 comment) just a minor nitpick http://gerrit.ovirt.org/#/c/24333/6/ovirt_hosted_engine_ha/agent/hosted_engine.py File ovirt_hosted_engine_ha/agent/hosted_engine.py: Line 62: return ret Line 63: return cleanup_wrapper Line 64: Line 65: Line 66: def float_or_none(v): how about try: return float(v) except ValueError: return None Line 67: if v == "None": Line 68: return None Line 69: else: Line 70: return float(v) -- To view, visit http://gerrit.ovirt.org/24333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icad82e819b653cd8b9210d0a71e0312fc6b20134 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
