Greg Padgett has posted comments on this change. Change subject: Separate the state machine into machine, states with logic and communication ......................................................................
Patch Set 5: (1 comment) Great change! http://gerrit.ovirt.org/#/c/24333/5/ovirt_hosted_engine_ha/agent/state_machine.py File ovirt_hosted_engine_ha/agent/state_machine.py: Line 158: self.hosted_engine.host_id, str(stats.local)) Line 159: Line 160: # create new data object with the newest stats at the Line 161: # beginning, we are not interested in more than Line 162: # 15 second history snapshots Old behavior tracked history approx. once/minute for 15 minutes. Does this pick up the last 15 samples regardless of time? It may affect the how the cpu load affects the score in EngineState.score(). Line 163: # namedtuple._replace makes a copy with updated values Line 164: new_data = old_data._replace( Line 165: history=(stats,) + old_data.history[:14], Line 166: stats=stats, -- To view, visit http://gerrit.ovirt.org/24333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icad82e819b653cd8b9210d0a71e0312fc6b20134 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
