Alon Bar-Lev has posted comments on this change. Change subject: 6. [WIP] core: Introducing configuration loader ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/24365/14/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java: Line 92: } Line 93: return result; Line 94: } Line 95: Line 96: public void load(EngineLocalConfig config) throws ConfigurationException { > We can do that, but it will pose an issue with the unit test (I do hope to we should find a solution... either not singleton or solve ut... Line 97: for (File directory : config.getExtensionsDirectories()) { Line 98: load(directory); Line 99: } Line 100: activate(); -- To view, visit http://gerrit.ovirt.org/24365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I182904177ec088e62b35bde870ec79725fabc4e4 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
