Alon Bar-Lev has posted comments on this change. Change subject: 6. [WIP] core: Introducing configuration loader ......................................................................
Patch Set 14: (3 comments) http://gerrit.ovirt.org/#/c/24365/14/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java: Line 92: } Line 93: return result; Line 94: } Line 95: Line 96: public void load(EngineLocalConfig config) throws ConfigurationException { why not read from private constructor? what benefit is to expose that? Line 97: for (File directory : config.getExtensionsDirectories()) { Line 98: load(directory); Line 99: } Line 100: activate(); Line 122: ExtensionEntry entry = Line 123: new ExtensionEntry(file); Line 124: ExtensionEntry alreadyLoded = loadedEntries.get(entry.getName()); Line 125: if (alreadyLoded != null) { Line 126: throw new ConfigurationException("Could not load the configuration file \"" you should really use String.format.... Line 127: + file.getAbsolutePath() Line 128: + "\". The configuration file + \"" + alreadyLoded.file.getAbsolutePath() Line 129: + "\" already has the name " Line 130: + entry.getName()); Line 132: loadedEntries.put(entry.name, entry); Line 133: Line 134: } catch (IOException exception) { Line 135: throw new ConfigurationException( Line 136: "Can't load object configuration file \"" + file.getAbsolutePath() + "\".", String.format? Line 137: exception); Line 138: } Line 139: } Line 140: } -- To view, visit http://gerrit.ovirt.org/24365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I182904177ec088e62b35bde870ec79725fabc4e4 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
