Alon Bar-Lev has posted comments on this change. Change subject: 6. [WIP] core: Introducing configuration loader ......................................................................
Patch Set 12: (6 comments) http://gerrit.ovirt.org/#/c/24365/12/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java: Line 57: } Line 58: Line 59: public Configuration getConfig() { Line 60: return config; Line 61: } I expect to actually load the module... jboss module or whatever and hold the reference here. Line 62: } Line 63: Line 64: private static final Logger log = LoggerFactory.getLogger(ConfigurationLoader.class); Line 65: private static volatile ConfigurationLoader instance = null; Line 103: } Line 104: } Line 105: } Line 106: Line 107: public void load(EngineLocalConfig config) throws ConfigurationException { move to public section... the benefit of having all public at one place is that in one glance one can see the class interface. Line 108: for (File directory : config.getExtensionsDirectories()) { Line 109: load(directory); Line 110: } Line 111: activate(); Line 110: } Line 111: activate(); Line 112: } Line 113: Line 114: private void loadFile(File file) throws ConfigurationException { so why do we need this function? can't we add this logic to the load(File)? Line 115: // Load the configuration file: Line 116: Configuration config = null; Line 117: try { Line 118: ExtensionEntry entry = Line 150: } Line 151: } Line 152: Line 153: public List<ExtensionEntry> getExtensionsByService(String serviceName) { Line 154: return serviceEntries.get(serviceName); this should check null and return empty list no? Line 155: } Line 156: Line 157: public ExtensionEntry getExtensionByName(String pluginName) throws ConfigurationException { Line 158: ExtensionEntry result = loadedEntries.get(pluginName); http://gerrit.ovirt.org/#/c/24365/12/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java: Line 230: log.warn("No extension configurations directories were provided"); Line 231: return Collections.emptyList(); Line 232: } Line 233: List<File> results = new ArrayList<File>(); Line 234: for (String currentPath : path.split(":")) { if not blank Line 235: results.add(new File(currentPath)); Line 236: Line 237: } Line 238: return results; http://gerrit.ovirt.org/#/c/24365/12/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 213: ENGINE_REPORTS_UI=${ENGINE_VAR}/reports.xml Line 214: Line 215: Line 216: ENGINE_EXTENSION_PATH="${ENGINE_USR}/extensions.d:${ENGINE_ETC}/extensions.d" Line 217: no need for trailing line. -- To view, visit http://gerrit.ovirt.org/24365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I182904177ec088e62b35bde870ec79725fabc4e4 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
