Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/24018/5/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java: Line 30: ")" + Line 31: "\\)" + Line 32: ")?" + Line 33: "\\s*" + Line 34: "" please use my exact indent... do not modify anything even spacing. Line 35: ); Line 36: private static final Logger log = Logger.getLogger(FirstMatchSimpleFilter.class); Line 37: private Map<String, Transport> transports = new HashMap<>(); Line 38: private List<FilterEntry> notify = new LinkedList<>(); Line 121: if (!ok) { Line 122: throw new IllegalArgumentException("Cannot parse filters"); Line 123: } Line 124: } Line 125: return Collections.unmodifiableList(ret); this is not required *unmodifiable" as you do not store reference. it should be added if at some point you add. this is why it is better to return plain array. but in this case no need for wrapper. Line 126: } Line 127: Line 128: public static class Recipient { Line 129: Line 185: if (transport != null){ Line 186: recipient = new Recipient(transport, name); Line 187: } else { Line 188: recipient = null; Line 189: } I sent you alternate cleaner solution for this. once again, please separate between the parsing and the data. Line 190: } Line 191: Line 192: public String getEventName() { Line 193: return eventName; -- To view, visit http://gerrit.ovirt.org/24018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0b94ee8665ff8030b36b463207e50beea44b47d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
