Alon Bar-Lev has posted comments on this change. Change subject: 4. [WIP] core: Introducing configuration loader ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24365/2/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationLoader.java: Line 88: log.error("An extension with the name \"{}\" is already loaded", name); Line 89: return; Line 90: Line 91: } Line 92: configurationNames.add(name); > Not sure I understood this comment. you should create a data class, with at least: class ExtensionEntry { File file; boolean enabled; String name; Properties props; } load it into an array, then iterate the array to perform ordering(in future) and act upon if enabled. the logic of loading should be separate from the logic of processing. Line 93: String position = config.getString(ExtensionManagerKeys.position.getKeyName()); Line 94: if (position != null) { Line 95: if (position.equalsIgnoreCase("first")) { Line 96: if (!firstDetected) { -- To view, visit http://gerrit.ovirt.org/24365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I182904177ec088e62b35bde870ec79725fabc4e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
