Alon Bar-Lev has posted comments on this change. Change subject: 4. [WIP] core: Introducing configuration loader ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24365/2/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManagerKeys.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManagerKeys.java: Line 1: package org.ovirt.engine.core.extensions.mgr; Line 2: Line 3: public enum ExtensionManagerKeys { if this enum is used only by one class, put it as private within that class. Line 4: Line 5: position("ovirt.engine.extension.position"), Line 6: name("ovirt.engine.extension.name"), Line 7: service("ovirt.engine.extension.service"), -- To view, visit http://gerrit.ovirt.org/24365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I182904177ec088e62b35bde870ec79725fabc4e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
