Alon Bar-Lev has posted comments on this change. Change subject: tools: Support snmp trap as a notification method. ......................................................................
Patch Set 24: (2 comments) http://gerrit.ovirt.org/#/c/22909/24/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/SnmpTrap.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/SnmpTrap.java: Line 89: target.setCommunity( Line 90: new OctetString(prop.getProperty(NotificationProperties.SNMP_COMMUNITY, address, false))); Line 91: target.setVersion(SnmpConstants.version2c); Line 92: for (String manager : prop.getProperty(NotificationProperties.SNMP_MANAGERS, address, false) Line 93: .split("\\s+")) { please use (compiled) re, similar to the examples I send you. Line 94: log.info(String.format("Generate an snmp trap for event: %s to address: %s ", Line 95: event.toString(), Line 96: address)); Line 97: http://gerrit.ovirt.org/#/c/22909/24/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java: Line 259: Line 260: private void validateSnmpAvailability() { Line 261: for (String snmpManager : getProperty(SNMP_MANAGERS).split("\\s+")) { Line 262: validateHost(SNMP_MANAGERS, snmpManager.replaceAll(":.*", "")); Line 263: } please use (compiled) re, similar to the examples I send you. Line 264: } Line 265: Line 266: private void validateFilter() { Line 267: String filter = getProperty(NotificationProperties.FILTER, true); -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
