Alon Bar-Lev has posted comments on this change. Change subject: tools: Support snmp trap as a notification method. ......................................................................
Patch Set 25: (2 comments) http://gerrit.ovirt.org/#/c/22909/25/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/SnmpTrap.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/SnmpTrap.java: Line 98: log.info(String.format("Generate an snmp trap for event: %s to address: %s ", Line 99: event.toString(), Line 100: address)); Line 101: Line 102: final String[] split = manager.split(":"); If you use regular expression please do not use split... just apply valid pattern, and extract from groups. Line 103: target.setAddress(new UdpAddress(split[0] + "/" + (split.length > 1 ? split[1] : 162))); Line 104: try { Line 105: snmp.send(v2pdu, target); Line 106: setChanged(); http://gerrit.ovirt.org/#/c/22909/25/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java: Line 261: } Line 262: Line 263: private void validateSnmpAvailability() { Line 264: for (String snmpManager : WHITESPACE_PATTERN.split(getProperty(SNMP_MANAGERS))) { Line 265: validateHost(SNMP_MANAGERS, snmpManager.substring(0, snmpManager.indexOf(":"))); why do you need indexOf if you use pattern? Line 266: } Line 267: } Line 268: Line 269: private void validateFilter() { -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
