Alon Bar-Lev has posted comments on this change. Change subject: tools: Support snmp trap as a notification method. ......................................................................
Patch Set 22: (2 comments) http://gerrit.ovirt.org/#/c/22909/22/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java: Line 223: public boolean isConfigured(String property) { Line 224: return !StringUtils.isEmpty(getProperty(property)); Line 225: } Line 226: Line 227: // Availability > Will remove, although I do not see why not accept text only changes that im I accept at different patch. this patch should be only snmp related. Line 228: private void validateEmailAvailability() { Line 229: // try to resolve MAIL_SERVER host Line 230: validateHost(NotificationProperties.MAIL_SERVER, getProperty(NotificationProperties.MAIL_SERVER)); Line 231: } Line 241: } Line 242: Line 243: private void validateSnmpAvailability() { Line 244: for (String snmpManager : getProperty(SNMP_MANAGERS).split("\\s+")) { Line 245: validateHost(SNMP_MANAGERS, snmpManager.replaceAll(":.*", "")); > Talked to Martin about this, Turns out there where several customers reques you both wrong. Line 246: } Line 247: } Line 248: Line 249: private void validateFilter() { -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
