Greg Sheremeta has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging ......................................................................
Patch Set 17: (2 comments) http://gerrit.ovirt.org/#/c/21052/17/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java: Line 11: * ****************************************************************************************** Line 12: * Line 13: */ Line 14: Line 15: SanStorageModelBase("SanStorageModelBase"), //$NON-NLS-1$ > Shouldn't all of these be upper case? Its a nitpick. In theory yes. In practice, for now I'm keeping them the exact same as the hashNames, and I have no control over those. I'll take a look at cleaning up hashNames at some point, and perhaps a mass rename will be in order then. Line 16: Line 17: add_bricks("add_bricks", "Volumes Tab > Bricks Sub-Tab > Add Brick"), //$NON-NLS-1$ //$NON-NLS-2$ Line 18: Line 19: add_bricks_confirmation("add_bricks_confirmation", "[gluster] In 'Add Bricks' context: this is a confirmation dialog with the following message: 'Multiple bricks of a Replicate volume are present on the same server. This setup is not optimal. Do you still want to continue?'"), //$NON-NLS-1$ //$NON-NLS-2$ Line 454: Line 455: reboot_virtual_machine("reboot_virtual_machine"); //$NON-NLS-1$ Line 456: Line 457: public final String name; Line 458: @SuppressWarnings("unused") > Why are we supressing warnings on comment but not name? I don't see a gette I might need help with this one. Since it's an enum, I'm accessing name directly -- after all, it's final. So, model.setHelpTag(HelpTag.configure.name) However, we never need the comment field in GWT code -- only need it in this file so python can parse it. I see the options as: 1. do nothing 2. add getters (meh) 3. delete the Suppress so it doesn't confuse anyone Line 459: private final String comment; Line 460: Line 461: HelpTag(String name) { Line 462: this.name = name; -- To view, visit http://gerrit.ovirt.org/21052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
