Greg Sheremeta has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging ......................................................................
Patch Set 10: (9 comments) http://gerrit.ovirt.org/#/c/21052/10/build/helptag.py File build/helptag.py: Line 61: look for help tags in the source code. Line 62: """ Line 63: tags = {} Line 64: if filename.endswith('.java') and os.path.isfile(filename): Line 65: f = open(filename) > with open(filename) as f: Done Line 66: lines = f.readlines() Line 67: f.close() Line 68: i = 0 Line 69: while i < len(lines): Line 62: """ Line 63: tags = {} Line 64: if filename.endswith('.java') and os.path.isfile(filename): Line 65: f = open(filename) Line 66: lines = f.readlines() > lines = f.read().splitlines() is better to handle various of issues Done Line 67: f.close() Line 68: i = 0 Line 69: while i < len(lines): Line 70: m = __RE_ANNOTATION.match(lines[i]) Line 63: tags = {} Line 64: if filename.endswith('.java') and os.path.isfile(filename): Line 65: f = open(filename) Line 66: lines = f.readlines() Line 67: f.close() > drop close Done Line 68: i = 0 Line 69: while i < len(lines): Line 70: m = __RE_ANNOTATION.match(lines[i]) Line 71: if m: Line 65: f = open(filename) Line 66: lines = f.readlines() Line 67: f.close() Line 68: i = 0 Line 69: while i < len(lines): > for i, line in enumerate(lines): Done Line 70: m = __RE_ANNOTATION.match(lines[i]) Line 71: if m: Line 72: name = "" Line 73: comment = "" http://gerrit.ovirt.org/#/c/21052/10/build/helptag_checker.py File build/helptag_checker.py: Line 50: pattern=r'"[^"]*"' Line 51: ) Line 52: Line 53: Line 54: def walkSource(sourcedir): > so you need to check only one file, no? This is a different, but similar, tool that has a new purpose. It does need to scan all the source code. It's just a tool to help me make sure no one missed any helpTag calls. I only intend to run it once in a great while, around release time when I'm working on documentation stuff. Line 55: """ Line 56: walk the source code and run func for each files's lines Line 57: """ Line 58: for parent, dnames, fnames in os.walk(sourcedir): Line 91: hashname = m.group("hashname").replace('"', '') \ Line 92: .replace('-', '_') Line 93: if lines[i-1].find(hashname) == -1 or \ Line 94: lines[i-1].find('setHelpTag') == -1: Line 95: message = message + ( > +=? Done Line 96: "HELPTAG HASHNAME MISMATCH:\n%s%s\n" Line 97: % (lines[i-1], lines[i]) Line 98: ) Line 99: Line 96: "HELPTAG HASHNAME MISMATCH:\n%s%s\n" Line 97: % (lines[i-1], lines[i]) Line 98: ) Line 99: Line 100: if message != "": > if message: Done Line 101: print fname Line 102: print message Line 103: Line 104: Line 98: ) Line 99: Line 100: if message != "": Line 101: print fname Line 102: print message > please use python3 compatible code. Done Line 103: Line 104: Line 105: def findDuplicateHelpTagCalls(sourcedir): Line 106: Line 142: findVariableHashNames(args.sourcedir) Line 143: findHashNamesWithoutHelpTag(args.sourcedir) Line 144: findDuplicateHelpTagCalls(args.sourcedir) Line 145: Line 146: sys.exit(ret) > you always exit with exit code 1 Done Line 147: Line 148: Line 149: if __name__ == "__main__": Line 150: main() -- To view, visit http://gerrit.ovirt.org/21052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
