Einav Cohen has posted comments on this change.
Change subject: engine: refactor: add Model attribute for help tagging
......................................................................
Patch Set 10:
> Why do we need this complexity? What is more safe?
as I mentioned before: one advantage is that CommonHelpTags can help avoid
typos that can happen if using a .properties file; e.g. things like the
following:
// code:
setHelpTag("0a72022e-ca4e-4751-8097-fd162078454c")
// .properties file:
12bf5f1b-5459-4c1f-a388-a9bfda5aefe1.id = short-desc
12bf5f1b-5459-4c1f-a380-a9bfda5aefe1.description = bla bla bla /* typo in the
dialog uuid here */
cannot happen if we are using CommonHelpTags.
using CommonHelpTags is not really a complexity - the data is just kept in a
.java format instead of a .properties format.
A .properties format can be auto-generated from the .java format with 0 effort,
if necessary (so let's call it a minor "complexity" but with a minor advantage
as well).
--
To view, visit http://gerrit.ovirt.org/21052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
