Alon Bar-Lev has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/21052/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/CommonHelpTags.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/CommonHelpTags.java: Line 7: public HelpTagData SanStorageModelBase(); Line 8: Line 9: @Name("add_bricks") Line 10: @Comment("Volumes Tab > Bricks Sub-Tab > Add Brick") Line 11: public HelpTagData add_bricks(); So for me to understand... einav... this what proves my point... instead of this function we can have meaningful string... Instead of having this class and: glusterSwiftModel.setHelpTag(helpTags.manage_gluster_swift().getName()); have: glusterSwiftModel.setHelpTag("dialog=xxx,entry=yyy", "bla bla bla bla bla bla bla bla bla") why do we need this class? I remember that in the past you told me that there can be same tag for two dialogs, I believe this is not required, we can have several tags for docteam to assign single URL if they want. Line 12: Line 13: @Name("add_bricks_confirmation") Line 14: @Comment("[gluster] In 'Add Bricks' context: this is a confirmation dialog with the following message: 'Multiple bricks of a Replicate volume are present on the same server. This setup is not optimal. Do you still want to continue?'") Line 15: public HelpTagData add_bricks_confirmation(); -- To view, visit http://gerrit.ovirt.org/21052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
