Francesco Romani has posted comments on this change. Change subject: dbscripts: fix password field length ......................................................................
Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/23133/3//COMMIT_MSG Commit Message: Line 9: the password column in the 'storage_server_connections' table has Line 10: a different type with respect to the corresponding parameter of Line 11: the Insertstorage_server_connection function. Line 12: Line 13: This trigger an SQL exception doing the following: > /s/trigger an SQL/trigger SQL Done Line 14: Line 15: - configure an ISCSI data domain (bug triggered on the first one, Line 16: but it should behave the same with the others too). Line 17: - in the 'New domain' window, issue fill all the fields, http://gerrit.ovirt.org/#/c/23133/3/packaging/dbscripts/create_tables.sql File packaging/dbscripts/create_tables.sql: Line 678: CREATE TABLE storage_server_connections ( Line 679: id character varying(50) NOT NULL, Line 680: connection character varying(250) NOT NULL, Line 681: user_name character varying(50), Line 682: password text, > No , this should be done only in an upgrade script Done Line 683: iqn character varying(128), Line 684: port character varying(50), Line 685: portal character varying(50), Line 686: storage_type integer NOT NULL, http://gerrit.ovirt.org/#/c/23133/3/packaging/dbscripts/upgrade/03_04_0510_change_storage_server_connections_password_length.sql File packaging/dbscripts/upgrade/03_04_0510_change_storage_server_connections_password_length.sql: Line 1: -- with ISCSI data domain, after a manual discovery of a Line 2: -- password protected target, the adding failed with SQL exception Line 3: -- due to the difference in length of the password field. Line 4: -- see https://bugzilla.redhat.com/show_bug.cgi?id=1052839 > Usually we don't mention bug numbers as part of the code Done Line 5: Line 6: alter table storage_server_connections alter column password type text; Line 2: -- password protected target, the adding failed with SQL exception Line 3: -- due to the difference in length of the password field. Line 4: -- see https://bugzilla.redhat.com/show_bug.cgi?id=1052839 Line 5: Line 6: alter table storage_server_connections alter column password type text; > you can use here fn_db_change_column_type as follow: Done -- To view, visit http://gerrit.ovirt.org/23133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5dcb58dd445216b43bbce63b342b96d5e225e6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
