Eli Mesika has posted comments on this change. Change subject: dbscripts: fix password field length ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/23133/3/packaging/dbscripts/create_tables.sql File packaging/dbscripts/create_tables.sql: Line 678: CREATE TABLE storage_server_connections ( Line 679: id character varying(50) NOT NULL, Line 680: connection character varying(250) NOT NULL, Line 681: user_name character varying(50), Line 682: password text, > Eli, should we change the create_tables.sql? No , this should be done only in an upgrade script Line 683: iqn character varying(128), Line 684: port character varying(50), Line 685: portal character varying(50), Line 686: storage_type integer NOT NULL, -- To view, visit http://gerrit.ovirt.org/23133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5dcb58dd445216b43bbce63b342b96d5e225e6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
