Francesco Romani has posted comments on this change. Change subject: dbscripts: fix password field length ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/23133/2/packaging/dbscripts/create_tables.sql File packaging/dbscripts/create_tables.sql: Line 678: CREATE TABLE storage_server_connections ( Line 679: id character varying(50) NOT NULL, Line 680: connection character varying(250) NOT NULL, Line 681: user_name character varying(50), Line 682: password text, > I think that update script should be enough, I'm not sure if create_tables At the moment I leaved it as it is, just let know if this should go away, Line 683: iqn character varying(128), Line 684: port character varying(50), Line 685: portal character varying(50), Line 686: storage_type integer NOT NULL, http://gerrit.ovirt.org/#/c/23133/2/packaging/dbscripts/upgrade/03_04_0410_fix_storage_server_connections_password_length.sql File packaging/dbscripts/upgrade/03_04_0410_fix_storage_server_connections_password_length.sql: Line 4: -- see https://bugzilla.redhat.com/show_bug.cgi?id=1052839 Line 5: Line 6: alter table storage_server_connections alter column password type text; Line 7: Line 8: Create or replace FUNCTION Getstorage_server_connectionsByKey(v_iqn VARCHAR(128) , > The function should be changed in storage_san_sp.sql not in the upgrade scr Done Line 9: v_connection VARCHAR(250), Line 10: v_port VARCHAR(50) , Line 11: v_portal VARCHAR(50) , Line 12: v_username VARCHAR(50) , -- To view, visit http://gerrit.ovirt.org/23133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5dcb58dd445216b43bbce63b342b96d5e225e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
