Ramesh N has posted comments on this change. Change subject: gluster: dao changes for volume capacity info ......................................................................
Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/23010/15/packaging/dbscripts/upgrade/03_04_0480_add_tables_for_gluster_volume_and_brick_details.sql File packaging/dbscripts/upgrade/03_04_0480_add_tables_for_gluster_volume_and_brick_details.sql: Line 1: -- Add gluster_volume_details table Line 2: CREATE TABLE gluster_volume_details Line 3: ( Line 4: volume_id UUID NOT NULL REFERENCES gluster_volumes(id) ON DELETE CASCADE, > Not sure if I like the fact this has no primary key. We have volume_id as the primary key constraint here. Line 5: total_space BIGINT, Line 6: used_space BIGINT, Line 7: free_space BIGINT, Line 8: _update_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT LOCALTIMESTAMP, Line 11: Line 12: -- Add gluster_volume_brick_details table Line 13: CREATE TABLE gluster_volume_brick_details Line 14: ( Line 15: brick_id UUID NOT NULL REFERENCES gluster_volume_bricks(id) ON DELETE CASCADE, > same here. We have brick_id as the primary key constraint here Line 16: total_space BIGINT, Line 17: used_space BIGINT, Line 18: free_space BIGINT, Line 19: _update_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT LOCALTIMESTAMP, -- To view, visit http://gerrit.ovirt.org/23010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d67b7ee22f4cb6839d0f14d3f27f3e22149ff22 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
