Kanagaraj M has posted comments on this change. Change subject: gluster: dao changes for volume capacity info ......................................................................
Patch Set 12: (6 comments) http://gerrit.ovirt.org/#/c/23010/12/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDao.java: Line 56: public void updateAllBrickTasksByHostIdBrickDirInBatch(Collection<GlusterBrickEntity> bricks); Line 57: Line 58: public void addBrickProperties(BrickProperties brickProperties); Line 59: Line 60: public void addBrickProperties(List<GlusterBrickEntity> bricks); Is there a reason not to pass List<BrickProperties> for batch add/update? Line 61: Line 62: public void updateBrickProperties(BrickProperties brickProperties); Line 63: Line 64: public void updateBrickProperties(List<GlusterBrickEntity> bricks); http://gerrit.ovirt.org/#/c/23010/12/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java: Line 240: public BrickProperties mapRow(ResultSet rs, int rowNum) Line 241: throws SQLException { Line 242: BrickProperties brickProperties = new BrickProperties(); Line 243: brickProperties.setTotalSize(rs.getLong("total_space")); Line 244: // brickProperties.setUsedSize(rs.getLong("used_space")); TODO: Can we add usedSize as a brick properties remove it if not required Line 245: brickProperties.setFreeSize(rs.getLong("free_space")); Line 246: return brickProperties; Line 247: } Line 248: } http://gerrit.ovirt.org/#/c/23010/12/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 5376: <value>2010-11-29 15:57:10</value> Line 5377: </row> Line 5378: </table> Line 5379: Line 5380: <table name="gluster_volume_brick_details"> use <space> instead of <tab> Line 5381: <column>brick_id</column> Line 5382: <column>total_space</column> Line 5383: <column>used_space</column> Line 5384: <column>free_space</column> Line 5403: <value>60000</value> Line 5404: <value>40000</value> Line 5405: <value>2010-11-29 15:57:10</value> Line 5406: </row> Line 5407: <row> same here Line 5408: <value>41eb430f-c2ed-435c-b4eb-e1e19173754e</value> Line 5409: <value>100000</value> Line 5410: <value>60000</value> Line 5411: <value>40000</value> http://gerrit.ovirt.org/#/c/23010/12/packaging/dbscripts/gluster_volumes_sp.sql File packaging/dbscripts/gluster_volumes_sp.sql: Line 440: Line 441: Create or replace FUNCTION UpdateGlusterVolumeCapacityInfo(v_volume_id UUID, Line 442: v_total_space bigint, Line 443: v_used_space bigint, Line 444: v_free_space bigint) UpdateGlusterVolumeDetails - just to be consistent with InsertGlusterVolumeDetails Line 445: RETURNS VOID Line 446: AS $procedure$ Line 447: BEGIN Line 448: UPDATE gluster_volume_details Line 475: Line 476: Create or replace FUNCTION UpdateGlusterVolumeBrickProperties(v_brick_id UUID, Line 477: v_total_space bigint, Line 478: v_used_space bigint, Line 479: v_free_space bigint) UpdateGlusterVolumeBrickDetails - just to be consistent with InsertGlusterVolumeBrickDetails Line 480: RETURNS VOID Line 481: AS $procedure$ Line 482: BEGIN Line 483: UPDATE gluster_volume_brick_details -- To view, visit http://gerrit.ovirt.org/23010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d67b7ee22f4cb6839d0f14d3f27f3e22149ff22 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
