Ramesh N has posted comments on this change. Change subject: gluster: dao changes for volume capacity info ......................................................................
Patch Set 13: (3 comments) http://gerrit.ovirt.org/#/c/23010/13/packaging/dbscripts/gluster_volumes_sp.sql File packaging/dbscripts/gluster_volumes_sp.sql: Line 189: Create or replace FUNCTION GetGlusterVolumeDetailsById(v_volume_id UUID) Line 190: RETURNS SETOF gluster_volume_details STABLE Line 191: AS $procedure$ Line 192: BEGIN Line 193: RETURN QUERY SELECT * > Please ident SP body Done Line 194: FROM gluster_volume_details Line 195: WHERE volume_id = v_volume_id; Line 196: END; $procedure$ Line 197: LANGUAGE plpgsql; Line 254: Create or replace FUNCTION GetBrickDetailsById(v_brick_id UUID) Line 255: RETURNS SETOF gluster_volume_brick_details STABLE Line 256: AS $procedure$ Line 257: BEGIN Line 258: RETURN QUERY SELECT * > same Done Line 259: FROM gluster_volume_brick_details Line 260: WHERE brick_id = v_brick_id; Line 261: END; $procedure$ Line 262: LANGUAGE plpgsql; http://gerrit.ovirt.org/#/c/23010/13/packaging/dbscripts/upgrade/03_04_0480_add_tables_for_gluster_volume_and_brick_details.sql File packaging/dbscripts/upgrade/03_04_0480_add_tables_for_gluster_volume_and_brick_details.sql: Line 1: Create or replace FUNCTION __temp_fn_db_add_gluster_volume_and_brick_details_tables() > I wonder why we need the function if all it is doing is just creating table I have removed the function and added the code to add table directly Line 2: RETURNS void Line 3: AS $function$ Line 4: BEGIN Line 5: -- Add gluster_volume_details table -- To view, visit http://gerrit.ovirt.org/23010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d67b7ee22f4cb6839d0f14d3f27f3e22149ff22 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
