Sergey Gotliv has posted comments on this change. Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/22951/12/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetIscsiBondsByStoragePoolIdQueryTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetIscsiBondsByStoragePoolIdQueryTest.java: Line 29: Line 30: when(getQueryParameters().getId()).thenReturn(storagePoolId); Line 31: when(getDbFacadeMockInstance().getIscsiBondDao()).thenReturn(iscsiBondDao); Line 32: when(iscsiBondDao.getAllByStoragePoolId(storagePoolId)).thenReturn(Collections.singletonList(iscsiBond)); Line 33: when(iscsiBondDao.getNetworkIdsByIscsiBondId((Guid) anyObject())).thenReturn(Collections.singletonList(networkId)); > consider replacing "(Guid) anyObject" with "any(Guid.class)" I modified that test according to Liron's comment from the previous patch set. Line 34: when(iscsiBondDao.getStorageConnectionIdsByIscsiBondId((Guid) anyObject())).thenReturn(Collections.singletonList(connectionId)); Line 35: Line 36: getQuery().executeQueryCommand(); Line 37: -- To view, visit http://gerrit.ovirt.org/22951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
