Shahar Havivi has posted comments on this change. Change subject: DB: Vm Init - new Feature ......................................................................
Patch Set 17: (6 comments) http://gerrit.ovirt.org/#/c/23022/17/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmInitDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmInitDAOTest.java: Line 7: import org.ovirt.engine.core.common.businessentities.VmStatic; Line 8: import org.ovirt.engine.core.compat.Guid; Line 9: Line 10: public class VmInitDAOTest extends BaseDAOTestCase { Line 11: private static final Guid EXISTING_VM_ID = new Guid("77296e00-0cad-4e5a-9299-008a7b6f4355"); > minor: change to FixturesTool.VM_RHEL5_POOL_57 Done Line 12: private static final Guid NEW_VM_ID = new Guid("77296e00-0cad-4e5a-9299-000000000000"); Line 13: Line 14: private VmInit vmInit; Line 15: private VmInitDAO vmInitDao; Line 40: Line 41: @Test Line 42: public void testGet() { Line 43: VmInit result = vmInitDao.get(EXISTING_VM_ID); Line 44: assert (result != null); > use assertNotNull Done Line 45: } Line 46: Line 47: @Test Line 48: public void testSave() { Line 51: init.setHostname("hostname"); Line 52: vmInitDao.save(init); Line 53: Line 54: VmInit result = vmInitDao.get(init.getId()); Line 55: assert (result != null && result.getHostname().equals("hostname")); > break into 2 lines: Done Line 56: } Line 57: Line 58: @Test Line 59: public void testUpdate() { Line 59: public void testUpdate() { Line 60: VmInit init = new VmInit(); Line 61: init.setId(NEW_VM_ID); Line 62: init.setHostname("newHostname"); Line 63: vmInitDao.save(init); > perforem get, save it (should be update?) and then compare Done Line 64: Line 65: VmInit result = vmInitDao.get(init.getId()); Line 66: assert (result != null && result.getHostname().equals("newHostname")); Line 67: } Line 62: init.setHostname("newHostname"); Line 63: vmInitDao.save(init); Line 64: Line 65: VmInit result = vmInitDao.get(init.getId()); Line 66: assert (result != null && result.getHostname().equals("newHostname")); > same Done Line 67: } Line 68: Line 69: @Test Line 70: public void testRemove() { Line 67: } Line 68: Line 69: @Test Line 70: public void testRemove() { Line 71: vmInitDao.remove(NEW_VM_ID); > this remove is empty. AFAIK db regenerates from features for each test. Done Line 72: Line 73: VmInit result = vmInitDao.get(NEW_VM_ID); Line 74: assertNull(result); Line 75: } -- To view, visit http://gerrit.ovirt.org/23022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6230e0543712cc8a8efd48ba45406ea43d0f778 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
