Shahar Havivi has posted comments on this change. Change subject: DB: Vm Init - new Feature ......................................................................
Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/23022/17/packaging/dbscripts/upgrade/03_04_0490_add_vm_init_table.sql File packaging/dbscripts/upgrade/03_04_0490_add_vm_init_table.sql: Line 14: networks TEXT DEFAULT NULL, Line 15: password TEXT DEFAULT NULL, Line 16: winkey VARCHAR(30) DEFAULT NULL, Line 17: custom_script TEXT DEFAULT NULL Line 18: ) WITH OIDS; > no primary key? why vm_id is not PK? it is look at the next line: ALTER TABLE ONLY vm_init ADD CONSTRAINT pk_vm_init PRIMARY KEY (vm_id); Line 19: Line 20: Line 21: -- ---------------------------------------------------------------------- Line 22: -- copy the domain and time_zone to the new vm_init table -- To view, visit http://gerrit.ovirt.org/23022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6230e0543712cc8a8efd48ba45406ea43d0f778 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
