Gilad Chaplik has posted comments on this change. Change subject: DB: Vm Init - new Feature ......................................................................
Patch Set 14: (4 comments) http://gerrit.ovirt.org/#/c/23022/14//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-01-15 15:48:25 +0200 Line 6: Line 7: DB: Vm Init - new Feature Line 8: Line 9: Summry: s/Summry/Summary/ Line 10: This Feature will allow persistent of Windows Sysprep and Cloud-Init Line 11: data to the Database. By persisting the data Admin can create a template Line 12: with VM-Init data that which will enable initialize VMs with relevant Line 13: Data. http://gerrit.ovirt.org/#/c/23022/14/packaging/dbscripts/upgrade/03_04_0470_add_vm_init_table.sql File packaging/dbscripts/upgrade/03_04_0470_add_vm_init_table.sql: Line 2: -- Add table "vm_init" Line 3: -- ---------------------------------------------------------------------- Line 4: CREATE TABLE vm_init Line 5: ( Line 6: vm_id UUID NOT NULL, I'm always for foreign key to vm_static, and delete on cascade, also will prevent duplicate entries for the same vm. Line 7: host_name TEXT DEFAULT NULL, Line 8: domain TEXT DEFAULT NULL, Line 9: authorized_keys TEXT DEFAULT NULL, Line 10: regenerate_keys BOOLEAN DEFAULT FALSE, http://gerrit.ovirt.org/#/c/23022/14/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 1173: v_dns_search_domains TEXT DEFAULT NULL, Line 1174: v_networks TEXT DEFAULT NULL, Line 1175: v_password TEXT DEFAULT NULL, Line 1176: v_winkey VARCHAR(30) DEFAULT NULL, Line 1177: v_custom_script TEXT DEFAULT NULL) default values for function feature was added in 8.4, but I yet didn't see it in our code (maybe I'm mistaken). I'd not introduce it now. Line 1178: RETURNS VOID Line 1179: Line 1180: AS $procedure$ Line 1181: BEGIN Line 1211: v_networks TEXT DEFAULT NULL, Line 1212: v_password TEXT DEFAULT NULL, Line 1213: v_winkey VARCHAR(30) DEFAULT NULL, Line 1214: v_custom_script TEXT DEFAULT NULL) Line 1215: RETURNS VOID same. Line 1216: AS $procedure$ Line 1217: BEGIN Line 1218: INSERT INTO vm_init(vm_id, host_name, domain, authorized_keys, regenerate_keys, time_zone, dns_servers, dns_search_domains, Line 1219: networks, password, winkey, custom_script) -- To view, visit http://gerrit.ovirt.org/23022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6230e0543712cc8a8efd48ba45406ea43d0f778 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
