Douglas Schilling Landgraf has posted comments on this change. Change subject: oVirt Node Upgrade: Support N configuration ......................................................................
Patch Set 23: (4 comments) I have tested and it shows the iso when click upgrade based on the validations, like when cluster is compatible. > I would have removed this function from VdsHandler as it is > not used by any other module. > but this is not that important. Agreed. We can do it in a simple and separate patch. http://gerrit.ovirt.org/#/c/14756/23/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java: Line 85 Line 86 Line 87 Line 88 Line 89 > yes, I am being annoying... but you do not need to define shouldAdd here no agreed Line 100 Line 101 Line 102 Line 103 Line 104 > or best remove it at all and use: Done Line 84: Line 85: boolean shouldAdd = false; Line 86: RpmVersion isoVersion = new RpmVersion(file.getName()); Line 87: Line 88: shouldAdd = ( > you can add boolean here removed Line 89: isoData.getVdsmCompatibilityVersion() != null && isIsoCompatibleForUpgradeByClusterVersion(isoData) || Line 90: vdsOsVersion != null && VdsHandler.isIsoVersionCompatibleForUpgrade(vdsOsVersion, isoVersion) Line 91: ); Line 92: Line 118: "cluster major {0} minor {1} iso major {2} minor {3}", Line 119: vdsClusterVersion.getMajor(), Line 120: vdsClusterVersion.getMinor(), Line 121: isoClusterVersion.getMajor(), Line 122: isoClusterVersion.getMinor() > I really want to see toString() within these classes, even for debug, calli Understood and agree, I will use from Version toString(). Line 123: ); Line 124: return (vdsClusterVersion.getMajor() == isoClusterVersion.getMajor() && vdsClusterVersion.getMinor() <= isoClusterVersion.getMinor()); Line 125: } Line 126: -- To view, visit http://gerrit.ovirt.org/14756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
