Douglas Schilling Landgraf has posted comments on this change.

Change subject: oVirt Node Upgrade: Support N configuration
......................................................................


Patch Set 22:

(1 comment)

http://gerrit.ovirt.org/#/c/14756/22/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java:

Line 123:             "cluster major {0} minor {1} iso major {2} minor {3}",
Line 124:             vdsClusterVersion.getMajor(),
Line 125:             vdsClusterVersion.getMinor(),
Line 126:             isoClusterVersion.getMajor(),
Line 127:             isoClusterVersion.getMinor()
> No need.
I meant, from my understanding.. no need.
Line 128:         );
Line 129:         return (vdsClusterVersion.getMajor() == 
isoClusterVersion.getMajor() && vdsClusterVersion.getMinor() <= 
isoClusterVersion.getMinor());
Line 130:     }
Line 131: 


-- 
To view, visit http://gerrit.ovirt.org/14756
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to