Alon Bar-Lev has posted comments on this change. Change subject: oVirt Node Upgrade: Support N configuration ......................................................................
Patch Set 22: (4 comments) http://gerrit.ovirt.org/#/c/14756/22/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java: Line 96 Line 97 Line 98 Line 99 Line 100 to be consistent: shouldAdd = VdsHandler.isIsoVersionCompatibleForUpgrade(vdsOsVersion, isoVersion)) no? but maybe: shouldAdd = ( isoData.getVdsmCompatibilityVersion() != null && isIsoCompatibleForUpgradeByClusterVersion(isoData) || vdsOsVersion != null && VdsHandler.isIsoVersionCompatibleForUpgrade(vdsOsVersion, isoVersion) ); anyway... why is the isIsoVersionCompatibleForUpgrade is in VdsHandler anyway? Yair? I also do not see isIsoVersionCompatibleForUpgrade compare release, is that intentional? Line 91: if (VdsHandler.isIsoVersionCompatibleForUpgrade(vdsOsVersion, isoVersion)) { Line 92: shouldAdd = true; Line 93: } Line 94: } else { Line 95: shouldAdd = true; isn't that an error? if non of the above match. Line 96: } Line 97: Line 98: if (shouldAdd) { Line 99: availableISOsList.add(isoVersion); Line 123: "cluster major {0} minor {1} iso major {2} minor {3}", Line 124: vdsClusterVersion.getMajor(), Line 125: vdsClusterVersion.getMinor(), Line 126: isoClusterVersion.getMajor(), Line 127: isoClusterVersion.getMinor() isn't there toString() for these objects? Line 128: ); Line 129: return (vdsClusterVersion.getMajor() == isoClusterVersion.getMajor() && vdsClusterVersion.getMinor() <= isoClusterVersion.getMinor()); Line 130: } Line 131: http://gerrit.ovirt.org/#/c/14756/22/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeInfo.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeInfo.java: Line 26: private List<Entry> info; Line 27: Line 28: public static synchronized OVirtNodeInfo getInstance() { Line 29: if (instance == null) { Line 30: instance = new OVirtNodeInfo(); please add sync protection, see EngineLocalConfig. Line 31: } Line 32: return instance; Line 33: } Line 34: -- To view, visit http://gerrit.ovirt.org/14756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
