Ramesh N has posted comments on this change. Change subject: gluster: vdsm change for fetching volume capacity info ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/23091/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeAdvancedDetails.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeAdvancedDetails.java: Line 115: this.capacityInfo = capacityInfo; Line 116: } Line 117: Line 118: @Override Line 119: public int hashCode() { > Dont we need entry for brick details as well in hashCode() and equals() met Done Line 120: final int prime = 31; Line 121: int result = 1; Line 122: result = prime * result + ((capacityInfo == null) ? 0 : capacityInfo.hashCode()); Line 123: result = prime * result + ((serviceInfo == null) ? 0 : serviceInfo.hashCode()); Line 133: return false; Line 134: if (getClass() != obj.getClass()) Line 135: return false; Line 136: GlusterVolumeAdvancedDetails other = (GlusterVolumeAdvancedDetails) obj; Line 137: if (capacityInfo == null) { > Can you use ObjectUtils.objectsEqual instead? Done Line 138: if (other.capacityInfo != null) Line 139: return false; Line 140: } else if (!capacityInfo.equals(other.capacityInfo)) Line 141: return false; http://gerrit.ovirt.org/#/c/23091/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java: Line 86: accessProtocols = new LinkedHashSet<AccessProtocol>(Arrays.asList(new AccessProtocol[]{ Line 87: AccessProtocol.GLUSTER, AccessProtocol.NFS})); Line 88: transportTypes = new LinkedHashSet<TransportType>(); Line 89: volumeType = GlusterVolumeType.DISTRIBUTE; Line 90: asyncTask = new GlusterAsyncTask(); > Initialize advancedDetails too? Done Line 91: } Line 92: Line 93: @Override Line 94: public Guid getId() { http://gerrit.ovirt.org/#/c/23091/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSizeInfo.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSizeInfo.java: Line 16: private Long freeSize; Line 17: Line 18: private Long usedSize; Line 19: Line 20: private Date updatedAt; > move this to VolumeAdvancedDetails? Done Line 21: Line 22: public GlusterVolumeSizeInfo() { Line 23: } Line 24: -- To view, visit http://gerrit.ovirt.org/23091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I126eb7057ee1cc9abb31c0a9579c48a5cccb8be0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
