Yair Zaslavsky has posted comments on this change. Change subject: gluster: vdsm change for fetching volume capacity info ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/23091/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeAdvancedDetailsVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeAdvancedDetailsVDSCommand.java: Line 33: } Line 34: } Line 35: } Line 36: if (getParameters().isDetailRequired()) { Line 37: if (getSucceeded()) { Not sure I understand why the nested if (getSucceded()) - what am I missing here? Line 38: executeVolumeStatusInfo(GlusterVolumeStatusOption.CLIENTS.name().toLowerCase()); Line 39: if (getSucceeded()) { Line 40: volumeAdvancedDetails.copyClientsFrom(result.getVolumeAdvancedDetails()); Line 41: executeVolumeStatusInfo(GlusterVolumeStatusOption.MEM.name().toLowerCase()); -- To view, visit http://gerrit.ovirt.org/23091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I126eb7057ee1cc9abb31c0a9579c48a5cccb8be0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
